Test Plan for July 2018 (0.6.85)

[ramya-rao-a]

If you got a notification from this issue, then you are part of the next update to the Go extension.
Thanks and Welcome!

As most of you know already, I am the sole maintainer of this project at the moment. I wanted to try something different for this next update.

Here I will be listing the features and the bug fixes that will go in the next update along with the the folks who logged the bugs/feature requests, those who upvoted it, and those who fixed it by sending PRs.

The idea is to get the folks behind this update to give the update a trial run before I release it.
I always do basic testing before every update. But because I dont work with Go in my day job, I always feel that someone who does Go more than me can help in testing tremendously.

And when I say "test", you can do a minimum pass of just installing the update and then do nothing special other than going about using VS Code like you do everyday. Or you can test the feature you requested/implemented or the bug you logged/fixed. Or you can test all of the below. Every bit helps.

Drop in a comment in this issue after 2 or 3 days of installing the update with your findings.
Also, let me know in the comments what you think of this model of me asking your help in testing an update before releasing it.

To install the update,

• Download https://github.com/Microsoft/vscode-go/blob/master/Go-latest.vsix
• Run code --install-extension Go-latest.vsix
• If the above fails with Error: end of central directory record signature not found, then clone this repo and use the Go-latest.vsix file from the cloned repo
• Reload VS Code

[ramya-rao-a]

Features:

• Prioritize current project import suggestions #1782 When suggesting unimported custom packages, show the ones form current workspace before the others. You need to set go.autocompleteUnimportedPackages to true to test this. cc @marwan-at-work)
• Feature request: Add import folder to workspace #1733 New command Go: Add Package to Workspace that will add the imported package under your cursor to the current workspace. cc @freman who logged and implemented this feature

Bug Fixes:

• Make autocomplete for inline functions optional #1779 Fix bug with function snippets such that they are not inserted when functions are being filling in as parameters of another function call. cc @kaskavalci who logged and fixed the bug. Also cc @doxxx who worked on the feature of function snippets a few updates earlier
• Linting and other on-save jobs much slower in July 2018 VSCode release #1775 perf issues when using linters. cc @StephenWeber who logged the issue
• debug hover string variable ...more appears #1777 bug in debug variable and hover when using multi byte characters. cc @kzhui125 who logged the bug and @xmattstrongx who fixed it
• impl not generating stubs from interface #1769 Fix error with Go: Generate Interface Stubs command when using on an interface that is defined inside an "internal" folder. cc @danf0rth who logged the bug and @itsjamie who implemented the actual feature last year.
• Autocomplete not suggest type variable when using mdempsky/gocode #1739 Fix bug where auto-completions dont show built-in types. cc @paulviks,@willxm, @iiinsomnia who logged the bug
• go binary in $GOROOT should be prioritized #1760 Look at GOROOT before PATH when looking for the Go binary. cc @FiloSottile who logged the issue
• Delete binary files created by delve after closing the debug session #1345 Clean up the debug binary that gets generated by delve at the end of the debugging session. cc @NexWeb

[doxxx]

#1779 does not appear to be fully fixed. I tried with go.useCodeSnippetsOnFunctionSuggestWithoutType set to true. Variables of func type are completed to just the variable name, but full functions are completed with their parameter list as well.

[doxxx]

#1782: I still get Go core packages suggested before my current workspace's packages. E.g. I have a package called git.mycompany.com/project/repo/internal/importer and when I type imp in another package I get suggestions in this order:

• import (keyword)
• go/importer
• git.mycompany.com/project/repo/internal/importer
• golang.org/x/tools/refactor/importgraph

#1769 works for me. I had actually noticed this bug yesterday, using the current release version of the extension. 👍

#1739 works for me.

I can also confirm the debug binary cleanup works for me on Windows as well.

[marwan-at-work]

Gordon, that's expected. Standard library comes first. But you now don't have to sift through the 100s of packages from your GOPATH as your CWD package comes at the top (after std lib and keywords etc)

…

On Thu, Jul 19, 2018 at 9:40 AM Gordon Tyler ***@***.***> wrote: #1782 <#1782>: I still get Go core packages suggested before my current workspace's packages. E.g. I have a package called git.mycompany.com/project/repo/internal/importer and when I type imp in another package I get suggestions in this order: - import (keyword) - go/importer - git.mycompany.com/project/repo/internal/importer - golang.org/x/tools/refactor/importgraph #1769 <#1769> works for me. I had actually noticed this bug yesterday, using the current release version of the extension. 👍 #1739 <#1739> works for me. I can also confirm the debug binary cleanup works for me on Windows as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1797 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APihdbOuNeMm9GQyiGfiPfACGz2e07ieks5uIIxcgaJpZM4VVhWK> .

-- Marwan Sulaiman Software Developer Mobile: 203-722-5772

[doxxx]

@marwan-at-work I suspected as much but wanted to mention it just to be sure. Thanks!

[ramya-rao-a]

Thanks for the feedback @doxxx! Can you update #1779 with the case that didnt work for you? We can continue the discussion there.

[kaskavalci]

#1733 is a very handy feature! However, there are couple of issues with currrent implementation.

1. If import path is named, then it doesn't work.
   import router "github.com/julienschmidt/httprouter"
2. If package is not in GOPATH already, command fails silently without adding the package.

[ramya-rao-a]

@kaskavalci For named import path, where did you keep your cursor before invoking the command? It works for me when the cursor is in the import path, but not on the alias.

I've pushed d2579a5 to add a msg when package not found.

[kaskavalci]

@ramya-rao-a I highlighted import path including the name. It works for unnamed paths but named paths it silently fails. Without highlighting, if cursor is anywhere on the import path line, it does work for me too. It may be bit confusing for new users.

[freman]

Hi @ramya-rao-a, @kaskavalci

I propose the following patch, unless there's other magic in the plugin already.

if (selectedText.length > 0) {
	let index = selectedText.indexOf('"')
	if (index > 0 && index < selectedText.length-1) {
		selectedText = selectedText.substr(index)
	}

	if (!selectedText.startsWith('"')) {
		selectedText = '"' + selectedText;
	}
	if (!selectedText.endsWith('"')) {
		selectedText = selectedText + '"';
	}
 	importPath = getImportPath(selectedText);
}

I've tested the following:

'some/path' => '"some/path"'
'"some/path' => '"some/path"'
'some/path"' => '"some/path"'
'"some/path"' => '"some/path"'
'thing "some/path' => '"some/path"'
'thing "some/path"' => '"some/path"'
'import thing "some/path"' => '"some/path"'

It does fall apart if someone selects multiple lines...

[ramya-rao-a]

@kaskavalci @freman I've pushed a fix that should take care of the above cases. Do try the latest vsix file and that should have the fix.
@freman Failing in case of multiple lines is ok. I've added a notification on error. That should be enough

[kaskavalci]

@ramya-rao-a all cases are working. The best part, it can import the selected text, not the whole import path. Thanks!

[freman]

@kaskavalci that's my favourite bit too, trust me after a week of playing with AWS import paths 😀

[zo0o0ot]

I'm glad you are working on the Delve debug files issue. Keep up the good work!

[ramya-rao-a]

Thanks everyone! 0.6.85 update is released.