Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

"gotoSymbol" failed when Chinese words are in comments #465

Closed
dbaeumer opened this issue Sep 1, 2016 · 9 comments
Closed

"gotoSymbol" failed when Chinese words are in comments #465

dbaeumer opened this issue Sep 1, 2016 · 9 comments

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Sep 1, 2016

From @cjqpker on September 1, 2016 3:24

  • VSCode Version: Code 1.4.0 (6276dcb0ae497766056b4c09ea75be1d76a8b679, 2016-08-04T16:41:29.513Z)
  • OS Version: Darwin x64 15.6.0

Steps to Reproduce:

  1. shift+cmd+o, input some keywords
    2.vscode locates a strange position

img_20160901_111603

Copied from original issue: microsoft/vscode#11363
@dbaeumer
Copy link
Member Author

dbaeumer commented Sep 1, 2016

Moving to the vscode-go repository.

@dbaeumer dbaeumer mentioned this issue Sep 1, 2016
Closed
@cjqpker
Copy link

cjqpker commented Sep 9, 2016

ha?

@lukehoban
Copy link
Contributor

What is the issue here? Could you share repro steps?

@cjqpker
Copy link

cjqpker commented Oct 14, 2016

language : golang
1.shift+cmd+o, input some keywords
2.select a function and press enter
2.vscode will locate a strange position

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Oct 14, 2016 •
edited
Loading

@cjqpker Can you share a sample code/repo where you see this?

I followed your repro steps and cannot see the issue. For me, after Step 1 and 2, cursor goes to the line where the selected function is defined.

I see that when you reported this initially, you were using VS Code 1.4
Can you upgrade to the latest (1.6.1) and try again?

@cjqpker
Copy link

cjqpker commented Oct 17, 2016

I tested some codes and find out this problem appears when annotations include Chinese words.

@cjqpker
Copy link

cjqpker commented Oct 17, 2016

@ramya-rao-a

@ramya-rao-a
Copy link
Contributor

@cjqpker We were able to repro this issue by using Chinese words in comments. Thanks for reporting!

@ramya-rao-a ramya-rao-a changed the title "gotoSymbol" failed in golang "gotoSymbol" failed when Chinese words are in comments Oct 17, 2016
@ramya-rao-a ramya-rao-a mentioned this issue Dec 30, 2016
Merged
@ramya-rao-a
Copy link
Contributor

@cjqpker The new release of the extension (0.6.52) has the fix for this issue

mattetti added a commit to mattetti/vscode-go that referenced this issue Jan 11, 2017
@mattetti
Merge branch 'master' of github.com:mattetti/vscode-go
461d4bb 
* 'master' of github.com:mattetti/vscode-go: (128 commits)
  Add telemetry support for the Go extension
  Add dlv path to error msg when dlv not found
  Fixes microsoft#465 outline offset problem in No-English language (microsoft#699)
  fix coverage display when editor changes to undefined (microsoft#693)
  Add support for reading http.proxy setting (microsoft#639)
  Fixing flaky unit tests
  Refactor for corner cases
  Reduce noise in console log due to errors from hover
  Changelog for next update 0.6.51
  Remove space after brackets in snippet as per microsoft#628
  Fixes microsoft#647 Strip version from autocompleted pkgs from gopkg.in (microsoft#659)
  Fixes microsoft#647 Support vendor pkgs from root of GOPATH/src (microsoft#660)
  Fixes microsoft#640 Use spawn to handle big data from gocode (microsoft#661)
  Fixed wrong workspace when one gopath is the substring of another. (microsoft#658)
  Fix "gotests" when generates test for current function for type methods (microsoft#657)
  Add benchmark function snippet (microsoft#648)
  Fix "Go to Definition" when running Go HEAD (microsoft#655)
  Fixes microsoft#642 Only add -d once to formatflags (microsoft#644)
  Updating Changelog and package.json for 0.6.50 update
  Log errors to console
  ...
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukehoban @dbaeumer @cjqpker @ramya-rao-a