This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 646
Package suggestion for _test.go #1220
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ba91b4a
Package suggestion for _test.go
uudashr 0ee2b62
Add semicolon
uudashr e1a7544
Package suggestion for _test.go
uudashr 0a57b24
Add semicolon
uudashr 3e7ac6f
Consider package suggestion with dir contains main.go
uudashr cf0c68a
Always resolve
uudashr bbcf7b2
Guest package name when the directory name consist of mutiple words
uudashr f9ad6fd
Fix typo
uudashr 5fa98c9
Guess all dirname
uudashr ba8958c
Use capital
uudashr 1948839
Use stat instead of readdir
ramya-rao-a b491535
Fallback proposedPkgName when main.go not found
uudashr 3aa842d
Moved guessPkg to utils so its reusable
ramya-rao-a File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of getting all files under the path and then checking for
main.go
, isn't it simpler to directly check forpath + 'main.go'
usingfs.statSync(filePath).isFile()
?