Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Copy formatFlags before modifications #1334

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

philk
Copy link
Contributor

@philk philk commented Nov 12, 2017

On the latest insiders build it looks like the workspace config objects are now frozen (which makes sense). I don't know if there's a "more correct" way to fix this but this seemed reasonable.

Fixes #1333

The workspace config objects are frozen causing the error

```
TypeError: Cannot add property 0, object is not extensible
```

Easiest solution is to just dupe the array before doing anything to it.
@ramya-rao-a
Copy link
Contributor

Thanks @philk!

@ramya-rao-a ramya-rao-a merged commit a6fddd1 into microsoft:master Nov 12, 2017
@philk philk deleted the fix_formatFlags_error branch November 12, 2017 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format on save (goreturns) no longer works after upgrade
2 participants