-
Notifications
You must be signed in to change notification settings - Fork 646
Add support for coverage markup #143
Add support for coverage markup #143
Conversation
…n/vscode-go into Add-support-for-coverage-markup
…ort-for-coverage-markup
@tampajohn Awesome 👍 One thing what I found: If the cursor is on a tested line and I want to add a new line with new code, then the next line and all new following lines will have the same background color as the tested line (green or red). Would be better to reset the background color for the new line/code if possible. |
@tecbot Hmmmm, I'm not super sure where the best place to tie into this is... @lukehoban I know I could do something using registerOnTypeFormattingEditProvider, but that seems kinda invasive... do you know a good place to handle resetting coverage when a document is dirty? |
Depends a bit on what experience you want exactly. You could try But do you think it makes sense to instead try to keep the coverage information around even after you make edits? |
+1 remove the coverage if start editing the code |
@tecbot Removing coverage for the file that's been edited, thanks for the onDidChangeTextDocument pointer @lukehoban |
What is the status of this PR? What’s missing for its merging? |
Finally got a chance to re-review this, and looks good. I've merged this in now along with a few minor changes. Thanks @tampajohn, and apologies for the 4 month delay 😄. |
…valuation Watch expressions are repeated over and over again while the program is running, pausing, continuing, etc, and the result is always displayed and continuously refreshed under WATCH. Unlike other types of evaluations (e.g. in REPL, where one expression is evaluated at a time, and the error can be buried among logging messages), there is no advantage to also showing the same error in a pop-up box. Fixes microsoft#143 Change-Id: I026955980d22e955e4af933bc68256dc320c3f56 GitHub-Last-Rev: 9a52492 GitHub-Pull-Request: golang/vscode-go#196 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236999 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Adding coverage highlighting to vscode-go. Adds setting "go.coverageOnSave" and command for performing coverage for current package. Addresses some of the desires of #80.