Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Do not suggest function parameters if passing it as an argument #1788

Merged
merged 2 commits into from
Jul 17, 2018

Conversation

kaskavalci
Copy link
Contributor

As per the suggestion: #1779 (comment)

This PR disables suggesting function parameters if passing the suggestion as an argument. If cursor ends with , or ) it skips parameter suggestion.

For more info: #1779

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt these additional checks be made only when suggest.class === 'var' ?

@kaskavalci
Copy link
Contributor Author

True, I missed that.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing.. Can you update the test Test Completion Snippets For Functions in the go.test.ts file to include this case?

@ramya-rao-a ramya-rao-a merged commit 43613e0 into microsoft:master Jul 17, 2018
@ramya-rao-a
Copy link
Contributor

Never mind, I've added the tests. Thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants