This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
fixed 1743, go.gopath and go.toolsGopath now expand ${env:XXX} #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
suggested changes
Oct 15, 2018
src/util.ts
Outdated
| @@ -443,7 +449,7 @@ export function getCurrentGoPath(workspaceUri?: vscode.Uri): string { | |||
| } | |||
| } | |||
|
|
|||
| const configGopath = config['gopath'] ? resolvePath(config['gopath'], currentRoot) : ''; | |||
| const configGopath = config["gopath"] ? resolvePath(substituteEnv(config["gopath"]), currentRoot) : "" | |||
There was a problem hiding this comment.
The introduction of double quotes and the missing semicolon in this line is causing linting errors.
|
|
ramya-rao-a
suggested changes
Oct 17, 2018
There was a problem hiding this comment.
Can you add some tests for the new substituteEnv function?
You can add a new file util.test.ts under https://github.com/Microsoft/vscode-go/tree/master/test/unit
Also, please sign the CLA. Else, I cannot merge the PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replicated the changes of @sphawk and I also deleted the flag m
Following the conversation #1743