Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix stackframe https://github.com/Microsoft/vscode-go/issues/1987 #2029

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Conversation

freezlite
Copy link
Contributor

September update for vscode breaks vscode-go debugger. Commit that cause trouble microsoft/vscode@cef0992#diff-2e2415aa74df8729e8b700ae772baf79R61

@ramya-rao-a
Copy link
Contributor

Thanks for the investigation @freezlite!

Can you provide a small sample code where I can get a repro of the <autogenerated> case? I cant repro it with the code that I have.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this issue is indeed related to microsoft/vscode#61088, then a better solution would be to check if location.file has absolute file path or not. i.e path.isAbsolute(location.file)

@freezlite
Copy link
Contributor Author

freezlite commented Oct 21, 2018

Delve return <autogenerated> for type casting for example, maybe in some different situations. I think no need to check for path if delve return autogenerated

@ramya-rao-a
Copy link
Contributor

I would still appreciate a code sample where <autogenerated> is returned by delve

@freezlite
Copy link
Contributor Author

Next stack after this
https://github.com/goji/goji/blob/master/dispatch.go#L17
2 0x0000000000a3e67c in bitbucket.org/my/project/vendor/goji%2eio.dispatch.ServeHTTP at /home/freezlite/go/src/bitbucket.org/my/project/vendor/goji.io/dispatch.go:17 3 0x0000000000a4200b in bitbucket.org/my/project/vendor/goji%2eio.(*dispatch).ServeHTTP at <autogenerated>:1

@ramya-rao-a
Copy link
Contributor

@freezlite And how are you debugging this? Using tests? I dont see any code calling https://github.com/goji/goji/blob/master/dispatch.go#L11

@freezlite
Copy link
Contributor Author

It's not mine code, but it crash debuger in vscode

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants