This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
support disabling document links, enable diagnostics by default #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
May 17, 2019
package.json
Outdated
| "documentLink": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "If true, the language server's document link feature will be enabled." |
There was a problem hiding this comment.
Can you update the description to include a little more details on what this feature would mean to the end user?
ramya-rao-a
reviewed
May 22, 2019
| "documentLink": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "If true, the language server will provide clickable Godoc links for import statements." |
ramya-rao-a
approved these changes
May 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue of stuck diagnostics seems to be solved, so we can now enable diagnostics by default.
Also, adds configurability for documentLink, which seems to have been requested by a few people, both on the issue tracker and on Slack.