Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

support disabling document links, enable diagnostics by default #2518

Merged
merged 2 commits into from
May 22, 2019
Merged

support disabling document links, enable diagnostics by default #2518

merged 2 commits into from
May 22, 2019

Conversation

stamblerre
Copy link
Contributor

The issue of stuck diagnostics seems to be solved, so we can now enable diagnostics by default.
Also, adds configurability for documentLink, which seems to have been requested by a few people, both on the issue tracker and on Slack.

package.json Outdated
"documentLink": {
"type": "boolean",
"default": true,
"description": "If true, the language server's document link feature will be enabled."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description to include a little more details on what this feature would mean to the end user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

"documentLink": {
"type": "boolean",
"default": true,
"description": "If true, the language server will provide clickable Godoc links for import statements."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to release

@ramya-rao-a ramya-rao-a merged commit 293bd31 into microsoft:master May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants