This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Adds support for running gocheck tests
#3222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looking through other PR's, it looks like the test failures in Travis are due to flaky tests possibly? |
|
Hey @tgturner Looks like this is your first PR contribution to this project, Thanks & Welcome! Unfortunately, we are in the midst of a repo move, see We are moving section in our readme for more details. We will have to close this PR as we are not accepting any PRs at the moment unless it is related to the move or critical bug fixes. Please consider creating this PR in the new home i.e https://github.com/golang/vscode-go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1921
This PR adds support for running tests that are written using the
gocheckpackage.Anytime we have access to an
activeTextEditor, when scanning symbols we also check for the existence of thegocheckpackage. If the package is found, tests are correctly extracted for code lens support, and when running tests correct flags are passed.I'm not familiar with typescript, but would find A LOT of value in this addition, so please let me know if you have any suggestions for improving the PR.