This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix gopath bin location search and error in error line parsing in windows #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - thanks for the fixes. |
lukehoban
added a commit
that referenced
this pull request
Nov 20, 2015
Fix gopath bin location search and error in error line parsing in windows
|
Fixes #19. |
| @@ -27,6 +28,13 @@ export function getBinPath(binname) { | |||
| return path.join(process.env["GOPATH"], "bin", binname); | |||
There was a problem hiding this comment.
workspaces will always be of .length > 0 and if no bin is found returning ws1:ws2/bin/name makes no sense.
There was a problem hiding this comment.
What would you suggest instead? Perhaps just return binname and rely on finding it in PATH?
Edit: Actually that won't work by itself since we use the returned path in calls to fs.existsSync.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I request to merge to correction tested for windows plugin usage.
First bin path extraction from gopath should be consistent, and in windows it is required to test file with it's extension
Build tool will emit errors like: myfile.go:4:6: expected 'STRING', found newline
where 4 is the line number and not 6