This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fixes #13 Rename using diffs and parse diffs using diff-parse/diff npm modules #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
gorename -d
that would give diffs instead of writing the files on disk with the refactored codegofmt
,go imports
andgoreturns
have an option to return diffs instead of the whole formatted content. Therefore update goFormat.ts to use the-d
option as well.diff
tool does not exist on the machine,gorename/gofmt/goimports/goreturns -d
will fail. Therefore, in these cases, revert to existing functionality which is write to disk files in case of rename and calculate diffs on our own in case of formattingdiff-match-patch
has a way to parse diff content only if the diff is for single file. Since rename can affect multiple files, this module cannot be used bygoRename.ts
diff
module can generate as well as parse diffs. Thereforediff-match-patch
has been replaced bydiff
module