This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
When delve fails, stop the debug sessions #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
commented
Feb 6, 2017
src/debugAdapter/goDebug.ts
Outdated
| @@ -268,9 +269,11 @@ class Delve { | |||
| connectClient(port, host); | |||
| } | |||
| }); | |||
| let that = this; | |||
There was a problem hiding this comment.
I am not sure why, but "this" in line 275 does not point to Delve object, it points to the ChildProcess which is why I had to resort to that = this
There was a problem hiding this comment.
You can use a fat arrow function (code => { ... }) instead of function, then this will be correct
There was a problem hiding this comment.
Oh ya! doh! I thought I was doing just that... need to get coffee
roblourens
reviewed
Feb 6, 2017
src/debugAdapter/goDebug.ts
Outdated
| @@ -268,9 +269,11 @@ class Delve { | |||
| connectClient(port, host); | |||
| } | |||
| }); | |||
| let that = this; | |||
There was a problem hiding this comment.
You can use a fat arrow function (code => { ... }) instead of function, then this will be correct
| @@ -388,6 +391,10 @@ class GoDebugSession extends DebugSession { | |||
| this.delve.onstderr = (str: string) => { | |||
| this.sendEvent(new OutputEvent(str, 'stderr')); | |||
| }; | |||
| this.delve.onclose = () => { | |||
| this.sendErrorResponse(response, 3000, 'Failed to continue: Check the debug console for details.'); | |||
There was a problem hiding this comment.
Cos it matches with the other message for when the delve.connection fails?
roblourens
approved these changes
Feb 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492