This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Ignore import statements in Go to Symbol in File feature #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go To Symbols in File feature currently lists all the import statements as symbols as well.
This becomes noisy for a file with a lot of imports and hinders symbol search as well.
See #680 (comment)
This PR ignores the import statements in the Go to Symbol File feature.
Will keep a setting to include them.
Based on the telemetry, we can see how many users turn it back on to include imports, and then take the call to remove the setting if needed.