Changes for hierarchical tree structure of sub-projects

[uiv24008]

Changes for hierarchical tree structure of sub-projects. Fix #945

[jdneo]

Hi @uiv24008

There are some CLA check that you need to do as a follow-up, please check #1592 (comment).

Meanwhile, I think it would be good if we can introduce a setting to control whether the tree view should be displayed hierarchical or flat.

[jdneo]

Took a look at IDEA and it's hierarchical by default and seems not able to switch to flat. So adding the setting to control the view style is not required.

[jdneo]

One feedback is about the place of the Tasks and Dependencies node of the parent project.

You can see that they are now placed at the bottom of the children nodes, which mixes with the above child project

I suggest to put it at the top of the child list. This is also how IDEA display:

[uiv24008]

Hi @jdneo,

I have modified the code and able to see Tasks and Dependencies node of the parent project as below:

Please let me know if it is fine, I will push the code changes

[jdneo]

Yes this is what I mean. Thank you!

[jdneo]

And don't forget this: #1592 (comment)

[jdneo]

Hi,

There are some lint errors. I think you can run the format task to fix them

After running the task you can rerun :extension:lint to check if it can pass

[uiv24008]

Hi,

There are some lint errors. I think you can run the format task to fix them

After running the task you can rerun :extension:lint to check if it can pass

Hi @jdneo , can you please mention the steps to reproduce the issue? I am not able to see "format" option under tasks

[jdneo]

@uiv24008 It is in the vscode-gradle, not the project you are testing with.

The repo has some restrictions on the code formatting, the task I mentioned are used to check and correct the code format.

[jdneo]

LGTM

[uiv24008]

I am trying to create .vsix file by running the command "vsce package", not able to create .vsix file and getting below error

Node version: v14.21.3

[jdneo]

@uiv24008 Could you cd to extension folder and try again?

If it's still not working, please try updating node to 18

[jdneo]

Hi @uiv24008, would you mind me closing this PR since we have #1612 for this?

[uiv24008]

Hi @sheng ***@***.***> Yes, you can close the PR #1592. It is not required Thanks & Regards, Shilpa S Patil From: Sheng Chen ***@***.***> Sent: Tuesday, October 8, 2024 6:50 AM To: microsoft/vscode-gradle ***@***.***> Cc: Patil, Shilpa ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/vscode-gradle] Changes for hierarchical tree structure of sub-projects (PR #1592) Hi @uiv24008<https://github.com/uiv24008>, would you mind me closing this PR since we have #1612<#1612> for this? - Reply to this email directly, view it on GitHub<#1592 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BKPB2UQRDXK7SYDZWQJ4HK3Z2MXLPAVCNFSM6AAAAABNFWT5FCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYGM4TMNBYGQ>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>