Add sync settings for java dependency viewer #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you share some background about the purpose of this PR? |
|
Use javaConfig.json instead for PDE development. This name is temporarily. |
testforstephen
previously approved these changes
May 20, 2019
yaohaizh
changed the title
jdneo
previously approved these changes
May 21, 2019
src/settings.ts
Outdated
| @@ -19,10 +20,13 @@ export class Settings { | |||
| && updatedConfig.syncWithFolderExplorer)) { | |||
| this._dependencyConfig = updatedConfig; | |||
| commands.executeCommand(Commands.VIEW_PACKAGE_REFRESH); | |||
| } else if (updatedConfig.autoRefresh !== this._dependencyConfig.autoRefresh) { | |||
| SyncHandler.updateFileWatcher(Settings.autoRefresh()); | |||
There was a problem hiding this comment.
Changed to SyncHandler.updateFileWatcher(updatedConfig.autoRefresh)
| @@ -19,10 +20,13 @@ export class Settings { | |||
| && updatedConfig.syncWithFolderExplorer)) { | |||
| this._dependencyConfig = updatedConfig; | |||
| commands.executeCommand(Commands.VIEW_PACKAGE_REFRESH); | |||
| } else if (updatedConfig.autoRefresh !== this._dependencyConfig.autoRefresh) { | |||
| SyncHandler.updateFileWatcher(Settings.autoRefresh()); | |||
| } else { | |||
| this._dependencyConfig = updatedConfig; | |||
There was a problem hiding this comment.
Move this line to the outer, make sure the cached config is synced with the latest.
testforstephen
approved these changes
May 21, 2019
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.