fix: Make export jar task unblock fetch task process #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
reviewed
Mar 7, 2023
| } | ||
| return this.tasks; | ||
| } | ||
|
|
||
| private static getLanguageServerStatusTimeout(): Promise<boolean> { |
There was a problem hiding this comment.
nit: just calling it languageServerStatusTimeout() should be fine. Since we do not get some real data here
jdneo
reviewed
Mar 8, 2023
| } | ||
|
|
||
| public async provideTasks(): Promise<Task[] | undefined> { | ||
| if (!await languageServerApiManager.ready()) { | ||
| const languageServerStatus = await Promise.race([languageServerApiManager.ready(), BuildArtifactTaskProvider.getLanguageServerStatusTimeout()]); |
There was a problem hiding this comment.
And let's extract this Promise.race statement to a method with document explaining the reason doing this.
There was a problem hiding this comment.
in 0f4564c we:
- extract the utility to languageServerApiManager, named
isReady(timeout) - rename original
isReadyfield toisServerReady
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #720
This PR contains two things: