Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Tycho version 4.0.5 to address proxy issues #1656

Closed
baronswindle opened this issue Jan 29, 2024 · 2 comments
Closed

Upgrade to Tycho version 4.0.5 to address proxy issues #1656

baronswindle opened this issue Jan 29, 2024 · 2 comments
Labels
eng Debts for engineering
Milestone

Comments

@baronswindle
Copy link
Contributor

baronswindle commented Jan 29, 2024

Tycho v4.0.3 and v4.0.4 — and possibly earlier versions as well — do not seem to handle proxy settings very well. Like many big companies, my employer only allows access to the internet via a proxy, and when I attempted to run npm run build-plugin in this repository, I got the following error message.

Failed to resolve target definition file:/path/to/vscode-java-test/java-extension/com.microsoft.java.test.target/com.microsoft.java.test.tp.target: Failed to load p2 metadata repository from location https://download.eclipse.org/buildship/updates/e423/snapshots/3.x/3.1.7.v20221108-1729-s/: Unable to read repository at https://download.eclipse.org/buildship/updates/e423/snapshots/3.x/3.1.7.v20221108-1729-s. Remote host terminated the handshake: Connection reset

Tycho v4.0.5 includes this change, which appears to address the issue. See change log for v4.0.5. And when I updated tycho-version from 4.0.3 to 4.0.5 locally, npm run build-plugin completely succeeded for me.

Are y'all open to this change?

@jdneo
Copy link
Member

jdneo commented Jan 31, 2024

Yes, it's totally fine to upgrade it if it can solve the issue.

PR is welcome.

baronswindle pushed a commit to baronswindle/vscode-java-test that referenced this issue Feb 10, 2024
This addresses an issue with proxy settings described in microsoft#1656
baronswindle pushed a commit to baronswindle/vscode-java-test that referenced this issue Feb 10, 2024
This addresses an issue with proxy settings described in microsoft#1656
jdneo pushed a commit that referenced this issue Feb 21, 2024
This addresses an issue with proxy settings described in #1656

Co-authored-by: Brandon John Lewis <brandon.lewis@capitalone.com>
@jdneo
Copy link
Member

jdneo commented Mar 5, 2024

addressed by #1664

@jdneo jdneo closed this as completed Mar 5, 2024
@jdneo jdneo added eng Debts for engineering and removed help wanted labels Mar 5, 2024
@jdneo jdneo added this to the 0.41.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng Debts for engineering
Projects
None yet
Development

No branches or pull requests

2 participants