Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve the accessibility of opening document #1129

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix: Improve the accessibility of opening document #1129

merged 1 commit into from
Jan 26, 2021

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jan 25, 2021

This PR contains following changes:

  • Use the VS Code built-in open command for the tree nodes in the test explorer
  • Since using the built-in command will lose the BI, using a event counter to track the ui operations
  • Better treat with the focus when opening documents from the test report.

Related with #1128

@jdneo jdneo added the bug label Jan 25, 2021
@jdneo jdneo added this to the 0.28.0 milestone Jan 25, 2021
@jdneo jdneo merged commit 5940a18 into master Jan 26, 2021
@jdneo jdneo deleted the cs/vscode-open branch January 26, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen testforstephen approved these changes

@Eskibear Eskibear Eskibear approved these changes

Assignees
No one assigned
Labels
accessibility enhancement
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jdneo @Eskibear @testforstephen