Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to Java 11 #1349

Closed
wants to merge 1 commit into from
Closed

chore: Migrate to Java 11 #1349

wants to merge 1 commit into from

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Dec 23, 2021

Now that the Java Language Support Extension has embedded JRE 17 to run all Java extensions, it's time to migrate to Java 11.

Signed-off-by: Sheng Chen sheche@microsoft.com

Signed-off-by: Sheng Chen <sheche@microsoft.com>
@jdneo jdneo added the eng Debts for engineering label Dec 23, 2021
@jdneo jdneo added this to the 0.34.0 milestone Dec 23, 2021
@testforstephen
Copy link
Contributor

The compiler version in some pom.xml is still 1.8.

<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>

@jdneo
Copy link
Member Author

jdneo commented Dec 23, 2021

The compiler version in some pom.xml is still 1.8.

That's the test runner for TestNG, which is just a common Java Application, not a OSGi bundle. So I think it's fine to keep it as 1.8

@testforstephen
Copy link
Contributor

I don't see you specify compiler version explicitly in your plugin pom.xml, I'm curious what's the target Java version when you're compile artifacts from cmd.

If there are 1.8 and 11 mixed in the final build artifacts, I'd rather not update to 11.

@jdneo jdneo modified the milestones: 0.34.0, backlog Jan 20, 2022
@karlvr
Copy link

karlvr commented Jan 23, 2022

@jdneo This line in JUnitLaunchConfigurationDelegate.java uses Set.of which is not available in Java 1.8, but the maven compiler plugin is set to use Java 1.8:

private static final Set<String> testNameArgs = Set.of("-test", "-classNames", "-packageNameFile", "-testNameFile");

So I think the Java version in the pom.xml referenced above might need to be updated to 11?

@jdneo jdneo closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng Debts for engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants