Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proper error reporting for old testng #1459

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

gayanper
Copy link
Contributor

TestNG version prior to like 6.7.x didn't failed the test method when
related configuration method failed. Instead they skipped all the
test methods which results in no error message in the Test Explorer.

This change add those missing information if the test method is skipped
followed by a configuration method failure.

TestNG version prior to like 6.7.x didn't failed the test method when
related configuration method failed. Instead they skipped all the
test methods which results in no error message in the Test Explorer.

This change add those missing information if the test method is skipped
followed by a configuration method failure.
@jdneo jdneo self-requested a review July 29, 2022 01:16
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works properly when exception happens at methods with TestNG configuration annotations.

Thank you for your contribution @gayanper!

@jdneo jdneo merged commit feb9d45 into microsoft:main Jul 29, 2022
@jdneo jdneo added the bug label Jul 29, 2022
@jdneo jdneo added this to the 0.37.0 milestone Jul 29, 2022
@gayanper gayanper deleted the fix_old_testng branch July 29, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants