feat: Support @TestFactory in JUnit 5 #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
reviewed
May 15, 2019
| return false; | ||
| } | ||
| // 'V' is void signature | ||
| if (method.isConstructor() || !"V".equals(method.getReturnType())) { |
...va.test.plugin/src/main/java/com/microsoft/java/test/plugin/searcher/JUnit5TestSearcher.java
Outdated
Show resolved
Hide resolved
Eskibear
approved these changes
May 16, 2019
yaohaizh
reviewed
May 16, 2019
| @@ -34,7 +35,19 @@ public TestKind getTestKind() { | |||
| public boolean isTestMethod(IMethod method) { | |||
| try { | |||
| final int flags = method.getFlags(); | |||
| return Flags.isPublic(flags) && super.isTestMethod(method); | |||
| if (Flags.isAbstract(flags) || Flags.isStatic(flags) || !Flags.isPublic(flags)) { | |||
There was a problem hiding this comment.
Lots of duplicate code, should refactor out.
yaohaizh
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #644
This change overrides the
isTestMethod()in the child class. It's because different test frameworks have different restrictions about the method signature. And it's hard to differentiate them in just one method.