-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling support in js-debug #388
Comments
Work will continue in April |
Im using 2020.5.1117 and the option doesn't come up for me in the callstack (VSCode stable not insiders) should i be seeing it? I was reading this https://code.visualstudio.com/updates/v1_45#_new-javascript-debugger and it looks like this options is available. the Debug: Take Performance Profile doesn't show either |
It looks like you're using the old debugger. You'll want to turn on the |
Oh my bad thanks. Second question, i have the flame extension installed i don't know how to get the flamegraph to show up? |
You can get the flame graph to show up by clicking the little 🔥 icon on the right of the filter box in the normal table view, or by using the "Reopen With" command. Startup perf is also something I need to create an issue for. The manual solution right now is to set |
ok my issue was that i didn't have the table plugin installed only the flame plugin |
Ah, yep. The table is installed by default on insiders but requires manual installation for the moment on stable. |
working great now, thanks! |
Can you please put links to the flame plugin and table plugin that need to be installed! |
Table: https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-js-profile-table I need to have better readmes for them 😛 |
Initial Feedbackit's looks great, just a couple of things i've noticed while using it FlamegraphScrolling direction Can the scrolling direction be changed to match up with Chrome Performance tab? In terms of going up and down Chrome does it weird, but maybe something like shift+scroll wheel is enough to scroll vertical? (it took me a while to realise you can hold down the left mouse click to move around, which is fine, it just wasn't obvious to me at first). Bottom of the flamegraph It seems right now the flamegraph snaps to the bottom of the editor and this isn't ideal Jumping between inspect files and back to flamegraph Flamegraph is not respecting What's weird is this is only happening for some files and not others. Upon inspection it seems to be getting the path from the sourcemap itself. I think you just need to prefix the I don't know what sort of queries this supports, is there documentation for this anywhere? |
Thank you for the feedback on this!
fixed in microsoft/vscode-js-profile-visualizer@9cc3d7d
Shift+wheel generally scrolls horizontally, so I made that scroll horizontally and alt+wheel screen vertically added in microsoft/vscode-js-profile-visualizer@89cb51e
added in microsoft/vscode-js-profile-visualizer@848578b
added in microsoft/vscode-js-profile-visualizer@d663ec2
We were looking at |
That’s incredible work thanks @connor4312! I had a question about the search bar, what does “start a query()” mean? Is there a query langauge for this? What’s a good way to filter out vendor files like node_modules from the view? |
This one is still not working for me, on the flamegraph i get I've sent you an email with a video describing the problem Version: |
There's a basic query 'language' right now (small docs). However I plan to remove support for it in favor of a simpler language like the marketplace uses and/or github, for example (this will not work today) you might write
Thanks, I'll take a look later this week |
If i understand correctly the query language doesn't work right now? |
It looks like the search in flamegraph view is only searching the top bar, if you search for anything else not at the top (bottom of the stack) it gets filtered out. Is this intentional? |
Not particularly. It will be fixed :) |
We want to explore performance measurement APIs in js-debug. In this month, we plan to:
Create a command that could be called by extension plugins to capture profiles
Expose a way for users to capture and save profiles
in untitled editorson complete Open profiles in untitled editors on complete #432Investigation into visualization options for the profiles (tracked in April visualization work #434)
Add an option to start the profiling before the program launches Add an option to start the profiling before the program launches #467
The text was updated successfully, but these errors were encountered: