-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exceptions in skipFiles not skipped #644
Comments
There was an issue that made skipping in node_internals non-effectual: #603 Does the nightly build solve this issue for you? |
Any news on this? Related: |
Not yet. I will probably tackle this at the beginning of next month. |
Looking forward to see this addressed as well. "debug.javascript.terminalOptions": {
"skipFiles": [
"node_modules/**",
"<node_internals>/**"
]
} Tried several options up to fully-qualified absolute filenames... to no avail. Also relates to microsoft/vscode#67039 I think |
Thanks all for the reports. Should be fixed in the next nightly build |
Still an issue for me. VSCode version: 1.51.1 Using WSL2 |
Please collect trace logs using the instructions in the issue template |
Submitted as a new issue here: #862 |
In the previous debugger, exceptions from locations in skipFiles would be ignored. This isn't working now, at least for the case of node_modules/**/*.js.
This is inconvenient when debugging Jest tests, which catch all exceptions, so it is necessary to tell the debugger to catch all exceptions.
I apologize that I don't have time right now to generate a minimal reproducer. Here is my debug config:
debug log:
VS Code Version: 1.47.2
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: