-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging v8.5 - always pauses in async_hooks.js on promise rejection #15464
Comments
Seeing the same issue |
Same issue here while debuging with WebStorm 2017.2.4 |
CC: @ak239 |
Same issue here while debuging with WebStorm 2017.2.4 |
cc @addaleax |
This is driving me absolutely mental. Anyone got any ideas? |
This also reproes in Node 8.6. Is anyone looking into this? Seems to be affecting quite a few people. If anyone is dealing with this in VS Code, there is a workaround - add "skipFiles": [
"<node_internals>/**"
], to your launch config to skip over this file automatically. |
@roblourens After I added the "skipFiles" to config, it starts to pause on this line every time:
|
and in Visual Studio current, not try fix |
For me the quick fix works on Node 8.6 with latest VSCode on Ubuntu 17.04 |
Same issue here while debugging NodeJS 8.6 with WebStorm 2017.2.4 on MacOS 10.13 |
Same issue with Node 8.6 while Debugging with PhpStorm 2017.2.4 on WIndows Server 2012 |
I debugged this one. On Inspector side we consider zero async_task_id as not valid task id and are not expecting to get this as asyncTaskStarted API argument. Task id zero triggers DebugBreak on inspector side. |
In V8Debugger code we don't expect task_id == null, e.g. asyncTaskStartedForStepping will trigger debug break on null as task_id. Let's filter task_id == null out. This issue is originally filed in Node.js: nodejs/node#15464 R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c Reviewed-on: https://chromium-review.googlesource.com/695808 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48265}
same issue here. webstorm 2017.2.4 & node 8.6 on ubuntu 16.04 |
Maybe some more movement on this? Created a sample project to help reproduce this, as requested in this thread. |
Fix for this problem: #15740 Ideal solution requires better understanding what does mean zero async task id in Node.js. |
Original commit message: should ignore asyncTask* with null In V8Debugger code we don't expect task_id == null, e.g. asyncTaskStartedForStepping will trigger debug break on null as task_id. Let's filter task_id == null out. This issue is originally filed in Node.js: nodejs#15464 R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c Reviewed-on: https://chromium-review.googlesource.com/695808 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#48265} Fixes nodejs#15464
Original commit message: should ignore asyncTask* with null In V8Debugger code we don't expect task_id == null, e.g. asyncTaskStartedForStepping will trigger debug break on null as task_id. Let's filter task_id == null out. This issue is originally filed in Node.js: #15464 R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c Reviewed-on: https://chromium-review.googlesource.com/695808 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48265} Fixes #15464 PR-URL: #16053 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
process.version |
@matrixapps I would suggest opening a new issue and referencing this one. This issue was specifically for |
Thanks for the feedback Matt. This is driving me up the wall! |
I did this:
and install the latest version of vscode and it works for me. I hope that helps. |
People dealing with async/await debugging craziness try: .vscode\launch.json
|
Hi, Thanks anyway! |
@matrixapps do you have a minimal test project to look at? What behavior are you facing with? |
In my current stack I see that it occurs on a Promise within lodash.reduce. I'm not explicitly calling this but its part of a much larger login sequence. The actual breakpoint happens in
My only resolution is to keep breakpoints OFF when I start debugging and then selectively turn them back on. :( |
Over a year later and this has still not been resolved!!!! |
will be 3 years soon.... |
:( |
Has this been addressed? It is also driving me crazy aha |
Yeah mine's the same.. still stopping on <node_internals> despite being correctly included in the skipFiles launch config |
Month ago I was good with |
I'm on vscode 1.47.3 and having this issue too. I can see that some have commented about this issue like 4/5 days ago so it must be something to do with recent updates? hmm |
same issue... |
I also started having this happen after a recent VS code update. I thought it had to do with the config of a new project I was working on, but I went back to one that worked a couple months ago and it is experiencing the same thing. I believe skipFiles no longer respects <node_internals> |
Yes, I've had to manually skip all of those files (even though they're under <node_internals> which no longer works!) with this:
Very annoying but it works in the short term.. |
I can confirm this issue. <node_internals> is not working on skipFiles |
For those that are landing on this page because skipFiles no longer works with node_internals, I can verify that these steps: |
Yes, it was working with the skipFiles for very long, and suddenly it stoppped working. I usually did this
I just tried it with the solution above and it can be solved with this too, at least for me it is enough
|
Following workaround worked for me. Looks like there is an issue with recognizing '<>' . |
How do you fix this without vsCode when running node via commandline? |
Lol how is this still and issue when debugging with chrome? |
For those struggling with the VS code debugger, this config helped (along with the skipFiles):
Apparently it is broken in Node v15 |
I'm using VS Code Insiders via Remote WSL, and I've tried every suggestion in this thread, including many combinations of |
Have this code:
When I debug it in Chrome Devtools or VS Code, even when it's set to not break on exceptions, it pauses on
function emitDestroyScript(asyncId) {...
in async_hook.js after the promise is rejected.The stack where it pauses is
The reason on the Debugger.paused message is "other".
The text was updated successfully, but these errors were encountered: