Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt new localization pipeline #1515

Merged
merged 7 commits into from
Jan 14, 2023
Merged

chore: adopt new localization pipeline #1515

merged 7 commits into from
Jan 14, 2023

Conversation

connor4312
Copy link
Member

src/dap/errors.ts Outdated Show resolved Hide resolved
@connor4312 connor4312 merged commit 175d912 into main Jan 14, 2023
@connor4312 connor4312 deleted the l10n branch January 14, 2023 21:30
@segevfiner
Copy link
Contributor

@connor4312 Hrmmm. The bootloader file is still bootloader.bundle.js in the built VSIX... But this PR changed it to bootloader.js, the extension now fails to find it.

P.S. I think 1.74.1 might have been built from old code rather than the tagged commit as it doesn't seem to include the change I did in https://github.com/microsoft/vscode-js-debug/blob/main/src/targets/node/extensionHostAttacher.ts and we might want to do this change in https://github.com/microsoft/vscode-js-debug/blob/main/src/targets/node/nodeAttacher.ts as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move built-in extensions off vscode-nls and on to the l10n API
4 participants