-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heap snapshots stuck "building graph layout..." #175
Comments
I notice that main has unreleased changes and wanted to see if the issue remains on latest main. I tried to test latest master but couldn't figure out testing the extension.
|
If you run the Toggle Developer Tools command, is there any errors shown there? Alternatively/preferably, are you able to share a heap snapshot where you see this reproduce? |
I'm not sure what a chrome heapsnapshot includes, from a security perspective. Would you mind confirming that your own chrome devtools heapsnapshots don't reproduce? If so I can look into sharing one from a blank VM or something. |
It includes some stuff about your program structure (by way of the heap structure) as well as strings allocated in the heap. If you prefer you can also email it to me at connor@xbox.com rather than posting publicly. |
Ok. Emailed, thanks |
Thanks! This week we're busy getting the next release out, but I'll take a look at this by the end of next week. |
Circling back here, how are you opening the graph? The graph as implemented currently only is relevant for selected objects from the table. It doesn't handle opening the entire heap snapshot (something I should make more explicit) because doing so for heaps of any reasonable size results in absolutely terrible performance as the graphs get very massive very quickly 🙂 |
How do you open it for a given object? |
It's not valid to open a file directly versus focusing a single element. Make it a webview panel instead to avoid the usability issue. For #175
I made a PR to remove the graph view from that switcher #179 |
Is there a place the graph icon is explained? In hindsight it's obvious but it might be worth explaining it in the extension landing page? |
Good idea, added (in the same PR) |
Looks great, thanks |
* fix: make heap snapshot graph a panel instead of an editor It's not valid to open a file directly versus focusing a single element. Make it a webview panel instead to avoid the usability issue. For #175 * add mention of retainers graph
If I take a heap snapshot in chrome devtools then open the graph mode in this viewer I just get
building graph layout...
it seems indefinitely. There's no error printed to theWindow
output logThe same is true of heap snapshots collected in the julia profiler, but that is more experimental, so chrome devtools is probably a better reproducer.
The text was updated successfully, but these errors were encountered: