-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IW in web #10131
Enable IW in web #10131
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10131 +/- ##
=====================================
- Coverage 55% 55% -1%
=====================================
Files 203 203
Lines 9238 9239 +1
Branches 1490 1490
=====================================
- Hits 5090 5089 -1
- Misses 3744 3748 +4
+ Partials 404 402 -2
|
We should probably convert the interactive tests to also run for the web. I did that for ipywidget tests and remote tests. I think you could likely follow a similar pattern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we've introduced a breaking change to not have an active interpreter controller for IW
Fixes #9717
One notable command that was not enabled is
execute selection
since it uses an execution service to get the applicable block of code from a selection and I haven't taken the time to convert that yet.