Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python code into src/platform/interpreter #12959

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Feb 28, 2023

Refactoring for #12832

This PR only moves files around, and nothing else.

@rebornix @amunger @roblourens /cc
Basically moved Python specific stuff like the below in src/platform/interpreter folder

  • Spawning python processes and running python code
  • Installation of Python packages

The plan is to move python specific stuff (where it makes sense) into a separate folder, so its easier to manage/maintain
Stuff like detection of python specific IPyWidgets, spawning python kernels might not necessarily be moved (yet), as those are very specific blocks of code/fucntionality

@DonJayamanne DonJayamanne marked this pull request as ready for review February 28, 2023 20:42
@DonJayamanne DonJayamanne merged commit 8fe8457 into main Feb 28, 2023
@DonJayamanne DonJayamanne deleted the movePythonFiles branch February 28, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants