Remove unnecessary args, ensure proper remote test #13555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 25, 2023
| traceVerbose('No default remote controller, hence returning the active interpreter'); | ||
| return createActiveInterpreterController(viewType, resource, this.interpreters, this.registration); | ||
| // This should never happen. | ||
| throw new Error('No default remote controller, hence returning the active interpreter'); |
There was a problem hiding this comment.
Tests should fail instead of running successfully under the wrong conditions.
If we're running remote tests, then we MUST run against a remote kernel
Previously we'd just log a message and tests would end up running against a local kernel, and thats completely wrong.
DonJayamanne
commented
May 25, 2023
| @@ -699,7 +695,6 @@ async function selectPythonRemoteKernelConnectionForActiveInterpreter( | |||
| export async function waitForKernelToGetAutoSelected( | |||
| notebookEditor: NotebookEditor, | |||
| expectedLanguage: string, | |||
| preferRemoteKernelSpec: boolean = false, | |||
There was a problem hiding this comment.
There's no need to specify this value, it can be derived from IS_REMOTE_NATIVE_TEST
DonJayamanne
commented
May 25, 2023
| @@ -63,5 +63,6 @@ export class JupyterServerSelectorCommand | |||
| this.handleMappings.set(handle, { uri: source, server: serverUri }); | |||
| // Set the uri directly | |||
| await this.serverSelector.addJupyterServer({ id: this.id, handle }); | |||
| this._onDidChangeHandles.fire(); | |||
There was a problem hiding this comment.
This was missing
DonJayamanne
changed the title
chrmarti
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12832