Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor execution results #14697

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Refactor execution results #14697

merged 3 commits into from
Nov 10, 2023

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Nov 9, 2023 •
edited
Loading

For #14669

@DonJayamanne DonJayamanne marked this pull request as ready for review November 9, 2023 23:29
rzhao271
rzhao271 requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because I assume the docstrings are external-facing.
If they're copied over from elsewhere they'll need to be corrected at the source too.

src/api.proposed.kernelApi.d.ts Outdated Show resolved Hide resolved
src/api.proposed.kernelApiAccess.d.ts Outdated Show resolved Hide resolved
DonJayamanne and others added 2 commits November 10, 2023 11:00
@DonJayamanne @rzhao271
Update src/api.proposed.kernelApi.d.ts
604c976 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@DonJayamanne @rzhao271
Update src/api.proposed.kernelApiAccess.d.ts
c73a9f0 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@rzhao271 rzhao271 added this to the November 2023 milestone Nov 10, 2023
@DonJayamanne DonJayamanne enabled auto-merge (squash) November 10, 2023 00:09
@DonJayamanne DonJayamanne merged commit 017fdab into main Nov 10, 2023
30 of 31 checks passed
@DonJayamanne DonJayamanne deleted the refactorKernelOutput branch November 10, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @rzhao271