Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments in API #14700

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Update comments in API #14700

merged 2 commits into from
Nov 10, 2023

Conversation

DonJayamanne
Copy link
Contributor

For #14669

@DonJayamanne DonJayamanne enabled auto-merge (squash) November 10, 2023 03:26
@DonJayamanne DonJayamanne marked this pull request as draft November 10, 2023 03:26
auto-merge was automatically disabled November 10, 2023 03:26

Pull request was converted to draft

@DonJayamanne DonJayamanne marked this pull request as ready for review November 10, 2023 03:50
@DonJayamanne DonJayamanne enabled auto-merge (squash) November 10, 2023 03:51
rzhao271
rzhao271 requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a change to the proposed API docstring

src/api.proposed.kernelCodeExecution.d.ts Outdated Show resolved Hide resolved
@DonJayamanne @rzhao271
Update src/api.proposed.kernelCodeExecution.d.ts
0e35bb8 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@DonJayamanne DonJayamanne merged commit c850abd into main Nov 10, 2023
32 checks passed
@DonJayamanne DonJayamanne deleted the asyncExec branch November 10, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @rzhao271