Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document execution result mime types #14794

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Document execution result mime types #14794

merged 5 commits into from
Nov 27, 2023
+9 −2

Conversation

DonJayamanne
Copy link
Contributor

For #14669

rzhao271
rzhao271 requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on API docstrings

DonJayamanne and others added 2 commits November 27, 2023 22:37
@DonJayamanne @rzhao271
Update src/api.proposed.kernelApi.d.ts
5701ea6 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@DonJayamanne @rzhao271
Update src/api.proposed.kernelApi.d.ts
12ae55a 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@DonJayamanne DonJayamanne enabled auto-merge (squash) November 27, 2023 22:37
rzhao271
rzhao271 requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More suggestions

DonJayamanne and others added 2 commits November 27, 2023 22:42
@DonJayamanne @rzhao271
Update src/api.proposed.kernelApi.d.ts
fcb14d9 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@DonJayamanne @rzhao271
Update src/api.proposed.kernelApi.d.ts
0903850 
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
@DonJayamanne DonJayamanne merged commit 9b56f87 into main Nov 27, 2023
31 checks passed
@DonJayamanne DonJayamanne deleted the documentMimeTypes branch November 27, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @rzhao271