Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC read buffer hangs onto a lot of memory if on big request or response is used. #544

Closed
dbaeumer opened this issue Nov 19, 2019 · 3 comments
Closed

JSON-RPC read buffer hangs onto a lot of memory if on big request or response is used. #544

dbaeumer opened this issue Nov 19, 2019 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities
Milestone
3.16

Comments

@dbaeumer
Copy link
Member

microsoft/vscode#84940 (comment)
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Nov 19, 2019
@dbaeumer dbaeumer added this to the 3.16 milestone Nov 19, 2019
@dbaeumer dbaeumer mentioned this issue Nov 19, 2019
Closed
@alexdima
Copy link
Member

There's one more performance aspect to it... If a response has 15MB, and it comes in chunks of 8KB, it means it will come in 1920 chunks. So 1920 times the buffer will be resized and the previous contents copied over.

@alexdima
Copy link
Member

I'd also not feel so bad about it, it is a common issue that has hit even nodejs -- nodejs/node#3145 -- italoacasas/node@cdfa056

@mjbvz mjbvz mentioned this issue Nov 25, 2019
Closed
@mjbvz
Copy link
Contributor

mjbvz commented Oct 15, 2020

See c446737 for an example fix

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Oct 15, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
3.16
Development

No branches or pull requests
3 participants
@dbaeumer @alexdima @mjbvz