Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS/TS protocol buffer hangs onto a lot of memory if on big request or response is used. #85565

Closed
mjbvz opened this issue Nov 25, 2019 · 1 comment
Closed

JS/TS protocol buffer hangs onto a lot of memory if on big request or response is used. #85565

mjbvz opened this issue Nov 25, 2019 · 1 comment
Assignees
@mjbvz
Labels
debt Code quality issues help wanted Issues identified as good community contribution opportunities javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
January 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 25, 2019

Extracted from #84940

The ProtocolBuffer has a leak where its internal buffer always grows, so if a response has the size 15MB, the internal buffer will always remain at 15MB and never shrink to something reasonable again.

microsoft/vscode-languageserver-node#544
@mjbvz mjbvz added the debt Code quality issues label Nov 25, 2019
@mjbvz mjbvz self-assigned this Nov 25, 2019
@mjbvz mjbvz mentioned this issue Nov 26, 2019
Closed
@mjbvz mjbvz added this to the Backlog milestone Jan 23, 2020
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Nov 20, 2020
@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues labels Oct 11, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 19, 2021

Closing in favor of microsoft/TypeScript#46417 which would let us remove ProtocolBuffer entirely

@mjbvz mjbvz closed this as completed Oct 19, 2021
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 19, 2021
@mjbvz mjbvz mentioned this issue Oct 19, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
@mjbvz mjbvz modified the milestones: Backlog, January 2022 Jan 10, 2022
mjbvz added a commit that referenced this issue Jan 10, 2022
@mjbvz
Use node ipc for communicating with TS Server
45c9b6f 
Fixes #85565
mjbvz added a commit that referenced this issue Jan 10, 2022
@mjbvz
Use node ipc for communication with TS Server (#135341)
deb9abe 
* Use node ipc for communicating with TS Server

For microsoft/TypeScript#46417

* Don't use ipc for stdio of we're not using ipc

* Use node ipc for communicating with TS Server

Fixes #85565
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues help wanted Issues identified as good community contribution opportunities javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
1 participant
@mjbvz