Add jsonc, aka json with comments, as a language identifier. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorshea
changed the title
connorshea
force-pushed
the
add-jsonc-identifier
branch
from
45873c2
to
31b41fa
Compare
|
Thanks. Just hit f5 from VS Code to launch vs code using this grammar. Will add a note on that |
|
This should be in the VS Code November insiders builds. Too late for us to take it into the upcoming VS Code 1.29 release |
|
That’s fine, thanks for the quick merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37. I wasn't able to test it on an actual build of VS Code since there are no instructions on how to do that, but I'm pretty sure it should work from what I understand of the codebase.
Maybe also worth looking at for comparison?: github-linguist/linguist#4171