Remove credential service call upon startup #17095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link the issue please |
Charles-Gagnon
approved these changes
Nov 9, 2021
kburtram
approved these changes
Nov 9, 2021
|
@cssuh Looks like you have some compile errors in the tests, make sure you run |
|
Also I'd suggest using one of the keywords to auto-close the issue when this PR is merged in (e.g. |
Charles-Gagnon
pushed a commit
that referenced
this pull request
Nov 11, 2021
* remove credential service call upon extension startup * fix build * fix lint * pr changes * only create azure controller once * fix build * fix build * pr fixes * fix tests * fix lint
Charles-Gagnon
added a commit
that referenced
this pull request
Nov 11, 2021
* remove credential service call upon extension startup * fix build * fix lint * pr changes * only create azure controller once * fix build * fix build * pr fixes * fix tests * fix lint Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential service is only called when a connection is created, this change will also improve extension startup times
fixes #17064