Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELECT ALL and FULL/NATURAL JOIN syntax to grammar #17508

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

Charles-Gagnon
Copy link
Contributor

Fixes #17507

Before :

image

After :

image

Note that natural joins aren't valid T-SQL - hence why they're showing up as red.

We probably shouldn't be even including natural joins in the grammar, but there was already some partial support for it so I decided that for now we'll just add this (since it's just colorization anyways).

Thanks @hanohrs for the submission and syntax update suggestion!

@Charles-Gagnon Charles-Gagnon changed the title Chgagnon/select all Add SELECT ALL and FULL/NATURAL JOIN syntax to grammar Dec 23, 2022
@Charles-Gagnon Charles-Gagnon merged commit 998c713 into main Dec 23, 2022
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/selectAll branch December 23, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SELECT ALL and some JOINs are not highlighted correctly
1 participant