Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Commit

Permalink
Add supportsLogPoints for #163
Browse files Browse the repository at this point in the history
  • Loading branch information
roblourens committed Mar 16, 2018
1 parent d0d1014 commit 4046c17
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 18 deletions.
30 changes: 18 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"license": "MIT",
"private": true,
"dependencies": {
"vscode-chrome-debug-core": "^3.23.6",
"vscode-debugadapter": "^1.27.0",
"vscode-chrome-debug-core": "^3.23.8",
"vscode-debugadapter": "^1.28.0-pre.2",
"vscode-nls": "^3.2.1"
},
"devDependencies": {
Expand All @@ -37,7 +37,7 @@
"vscode": "^1.1.9",
"vscode-chrome-debug-core-testsupport": "^4.0.0",
"vscode-debugadapter-testsupport": "^1.25.0",
"vscode-debugprotocol": "^1.27.0",
"vscode-debugprotocol": "^1.28.0-pre.1",
"vscode-nls-dev": "^3.0.7"
},
"main": "./out/src/extension",
Expand Down
8 changes: 5 additions & 3 deletions src/nodeDebugAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Copyright (C) Microsoft Corporation. All rights reserved.
*--------------------------------------------------------*/

import {ChromeDebugAdapter, chromeUtils, ISourceMapPathOverrides, utils as CoreUtils, logger, telemetry as CoreTelemetry, ISetBreakpointResult, ISetBreakpointsArgs, Crdp} from 'vscode-chrome-debug-core';
import {ChromeDebugAdapter, chromeUtils, ISourceMapPathOverrides, utils as CoreUtils, logger, telemetry as CoreTelemetry, ISetBreakpointResult, ISetBreakpointsArgs, Crdp, InternalSourceBreakpoint} from 'vscode-chrome-debug-core';
const telemetry = CoreTelemetry.telemetry;

import {DebugProtocol} from 'vscode-debugprotocol';
Expand Down Expand Up @@ -71,7 +71,9 @@ export class NodeDebugAdapter extends ChromeDebugAdapter {
localize = nls.config({ locale: args.locale })();
}

return super.initialize(args);
const capabilities = super.initialize(args);
capabilities.supportsLogPoints = true;
return capabilities;
}

public async launch(args: ILaunchRequestArguments): Promise<void> {
Expand Down Expand Up @@ -588,7 +590,7 @@ export class NodeDebugAdapter extends ChromeDebugAdapter {
/**
* Override addBreakpoints, which is called by setBreakpoints to make the actual call to Chrome.
*/
protected addBreakpoints(url: string, breakpoints: DebugProtocol.SourceBreakpoint[]): Promise<ISetBreakpointResult[]> {
protected addBreakpoints(url: string, breakpoints: InternalSourceBreakpoint[]): Promise<ISetBreakpointResult[]> {
return super.addBreakpoints(url, breakpoints).then(responses => {
if (this._entryPauseEvent && !this._finishedConfig) {
const entryLocation = this._entryPauseEvent.callFrames[0].location;
Expand Down

0 comments on commit 4046c17

Please sign in to comment.