Skip to content

Commit

Permalink
fix: node-addon-api exception handling (#47)
Browse files Browse the repository at this point in the history
* fix: node-addon-api exception handling

* chore: bump version
  • Loading branch information
deepak1556 authored Oct 3, 2024
1 parent c45ebd9 commit 61db6fc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@
"targets": [
{
"target_name": "vscode-sqlite3",
"cflags!": [ "-fno-exceptions" ],
"cflags_cc!": [ "-fno-exceptions" ],
"xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
"xcode_settings": {
"CLANG_CXX_LIBRARY": "libc++",
# Target depends on
# https://chromium.googlesource.com/chromium/src/+/master/build/config/mac/mac_sdk.gni#22
"MACOSX_DEPLOYMENT_TARGET": "10.11",
},
"dependencies": [
"<!(node -p \"require('node-addon-api').targets\"):node_addon_api_except"
],
"msvs_configuration_attributes": {
"SpectreMitigation": "Spectre"
},
"msvs_settings": {
"VCCLCompilerTool": {
"ExceptionHandling": 1,
"AdditionalOptions": [
"/guard:cf",
"/w34244",
Expand Down Expand Up @@ -67,7 +67,7 @@
"src/node_sqlite3.cc",
"src/statement.cc"
],
"defines": [ "NAPI_DISABLE_CPP_EXCEPTIONS=1", "NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS" ]
"defines": [ "NODE_API_SWALLOW_UNTHROWABLE_EXCEPTIONS" ]
},
#{
# "target_name": "action_after_build",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@vscode/sqlite3",
"description": "Asynchronous, non-blocking SQLite3 bindings",
"version": "5.1.7-vscode",
"version": "5.1.8-vscode",
"homepage": "https://github.com/microsoft/vscode-node-sqlite3",
"author": {
"name": "Mapbox",
Expand Down

0 comments on commit 61db6fc

Please sign in to comment.