-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-think PR creation flow #4403
Labels
Milestone
Comments
92 tasks
91 tasks
90 tasks
76 tasks
74 tasks
alexr00
added a commit
that referenced
this issue
Jun 15, 2023
alexr00
added a commit
that referenced
this issue
Jun 15, 2023
This was referenced Jun 20, 2023
Closed
Merged
alexr00
added a commit
that referenced
this issue
Jun 26, 2023
Add for compare only on new view Part of #4403
alexr00
added a commit
that referenced
this issue
Jun 26, 2023
Add for compare only on new view Part of #4403
alexr00
added a commit
that referenced
this issue
Jul 4, 2023
and reuse quickpicks from the PR description Part of #4403
alexr00
added a commit
that referenced
this issue
Jul 4, 2023
and reuse quickpicks from the PR description Part of #4403
54 tasks
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feedback from @burkeholland: "Why do we have an intermediate view in the viewlet when creating a PR, why not just use a Custom Editor to make it look like something users on GitHub are used to?" Using the Custom Editor in the Editor view that looks like the final Summary view would also make the transition calmer.
A benefit of showing the Creation view in the viewlet is that it makes it easy for users to preview the files their PR is touching.
I would just like if we re-think this, and if we decide that the leaving it in the Viewlet is the way to go then we should see how to polish the current experience.
@alexr00 ideally we should add some telemetry to see what percentage of users see the Creation view and do not finish creating it. And then explore how can we improve those numbers?
fyi @daviddossett for ideas
Current view:
The text was updated successfully, but these errors were encountered: