You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
open a PR on VS Code and navigate to the PR page.
Arrow down through until you get, for example, to the person that open the PR, or to any other link to a GitHub profile for that matter.
Expected behavior is to hear the link text "John Doe", and then however the screen reader announces the link role.
Obtained behavior is: you first hear "https://github.com/john-doe, [link role announcement]", and then you do get the link text "John Doe + [ link role announcement]"
I would expect this to work just like on the GitHub website, where the link text only is read by the screen readers.
Extension version: 0.97.2024090514
VS Code version: Code 1.93.0 (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:02:38.431Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2
We put the full link in the element's title, which is why it's getting read. I tried adding an aria-label, but the title still gets read by NVDA. This appears to be by design according to NVDA: nvaccess/nvda#7841.
I'll add the aria-label, but I don't think the behavior you experience will change.
We also want to have the title to show for sighted users, and we don't want to cause inconsistencies with how screen readers read aria-label and title. These things are in conflict.
Type: Bug
With a screen reader running:
open a PR on VS Code and navigate to the PR page.
Arrow down through until you get, for example, to the person that open the PR, or to any other link to a GitHub profile for that matter.
Expected behavior is to hear the link text "John Doe", and then however the screen reader announces the link role.
Obtained behavior is: you first hear "https://github.com/john-doe, [link role announcement]", and then you do get the link text "John Doe + [ link role announcement]"
I would expect this to work just like on the GitHub website, where the link text only is read by the screen readers.
Extension version: 0.97.2024090514
VS Code version: Code 1.93.0 (4849ca9bdf9666755eb463db297b69e5385090e3, 2024-09-04T13:02:38.431Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
A/B Experiments
The text was updated successfully, but these errors were encountered: