Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting review failed: GraphQL error: Fragment ReviewComment was used, but not defined #6474

Closed
chrmarti opened this issue Nov 13, 2024 · 10 comments
Assignees

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Nov 13, 2024

Type: Bug

Image

Extension version: 0.101.2024111304
VS Code version: Code - Insiders 1.96.0-insider (9b365cafae763d229e999f353831458761aff1cd, 2024-11-11T05:05:11.976Z)
OS version: Darwin arm64 23.6.0
Modes:
Connection to 'dev-container+7b22686f737450617468223a222f55736572732f6368726d617274692f446576656c6f706d656e742f7265706f732f736d6b747374222c226c6f63616c446f636b6572223a66616c73652c2273657474696e6773223a7b22636f6e74657874223a226465736b746f702d6c696e7578227d2c22636f6e66696746696c65223a7b22246d6964223a312c22667350617468223a222f55736572732f6368726d617274692f446576656c6f706d656e742f7265706f732f736d6b7473742f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c2270617468223a222f55736572732f6368726d617274692f446576656c6f706d656e742f7265706f732f736d6b7473742f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c22736368656d65223a2266696c65227d7d' could not be established

System Info
Item Value
CPUs Apple M1 Max (10 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) 3, 3, 4
Memory (System) 64.00GB (0.50GB free)
Process Argv --crash-reporter-id 7aad610c-0e6b-48aa-ba87-b704b1b543cf
Screen Reader no
VM 0%

Connection to 'dev-container+7b22686f737450617468223a222f55736572732f6368726d617274692f446576656c6f706d656e742f7265706f732f736d6b747374222c226c6f63616c446f636b6572223a66616c73652c2273657474696e6773223a7b22636f6e74657874223a226465736b746f702d6c696e7578227d2c22636f6e66696746696c65223a7b22246d6964223a312c22667350617468223a222f55736572732f6368726d617274692f446576656c6f706d656e742f7265706f732f736d6b7473742f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c2270617468223a222f55736572732f6368726d617274692f446576656c6f706d656e742f7265706f732f736d6b7473742f2e646576636f6e7461696e65722f646576636f6e7461696e65722e6a736f6e222c22736368656d65223a2266696c65227d7d' could not be established

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
vscod805cf:30301675
vsaa593:30376534
py29gd2263:31024238
c4g48928:30535728
a9j8j154:30646983
962ge761:30841072
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
cppperfnew:30980852
pythonait:30973460
9c06g630:31013171
dvdeprecation:31040973
dwnewjupyter:31046869
newcmakeconfigv2:31071590
impr_priority:31057980
nativerepl1:31134653
pythonrstrctxt:31093868
nativeloc1:31118317
cf971741:31144450
e80f6927:31120813
12bdf347:31141542
iacca1:31150324
notype1:31143044
dwcopilot:31158714
h409b430:31177054
2929b438:31176400

@chrmarti chrmarti changed the title GraphQL error Starting review failed: GraphQL error: Fragment ReviewComment was used, but not defined Nov 13, 2024
@chrmarti
Copy link
Contributor Author

Contrary to what the issue reporter mentions, this was not with a dev container.

This was while reviewing devcontainers/cli#852.

The log is not very detailed:

2024-11-13 09:17:49.068 [info] FolderRepositoryManager+0> Found GitHub repo for pr #852: yes
2024-11-13 09:17:50.389 [info] FolderRepositoryManager+0> Found GitHub pr repo for pr #852: yes
2024-11-13 09:17:51.647 [info] PullRequestTree> Local files have changed, refreshing Files node
2024-11-13 09:17:51.716 [info] PullRequestTree> Getting children for Files node
2024-11-13 09:17:51.716 [info] PullRequestTree> Got all children for Files node
2024-11-13 09:17:52.136 [error] GitHubRepository+0> Error querying GraphQL API: GraphQL error: Fragment ReviewComment was used, but not defined. useAndDefineFragment
2024-11-13 09:17:52.680 [error] GitHubRepository+0> Error querying GraphQL API: GraphQL error: Fragment ReviewComment was used, but not defined. useAndDefineFragment
2024-11-13 09:17:52.681 [error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Fragment ReviewComment was used, but not defined
2024-11-13 09:17:52.681 [info] PullRequestTree> Review threads have changed, refreshing Files node
2024-11-13 09:17:52.681 [info] PullRequestTree> Review threads have changed, refreshing Commits node
2024-11-13 09:17:52.681 [info] PullRequestTree> Comments have changed, refreshing Files node
2024-11-13 09:17:52.681 [info] PullRequestTree> Comments have changed, refreshing Commits node
2024-11-13 09:17:52.705 [info] PullRequestTree> Getting children for Files node
2024-11-13 09:17:52.705 [info] PullRequestTree> Got all children for Files node
2024-11-13 09:17:52.893 [info] PullRequestTree> Getting children for Files node
2024-11-13 09:17:52.894 [info] PullRequestTree> Got all children for Files node
2024-11-13 09:22:53.346 [info] FolderRepositoryManager+0> Found GitHub repo for pr #852: yes
2024-11-13 09:22:54.469 [info] FolderRepositoryManager+0> Found GitHub pr repo for pr #852: yes
2024-11-13 09:22:55.708 [info] PullRequestTree> Local files have changed, refreshing Files node
2024-11-13 09:22:56.160 [error] GitHubRepository+0> Error querying GraphQL API: GraphQL error: Fragment ReviewComment was used, but not defined. useAndDefineFragment
2024-11-13 09:22:56.586 [error] GitHubRepository+0> Error querying GraphQL API: GraphQL error: Fragment ReviewComment was used, but not defined. useAndDefineFragment
2024-11-13 09:22:56.586 [error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Fragment ReviewComment was used, but not defined
2024-11-13 09:22:56.586 [info] PullRequestTree> Review threads have changed, refreshing Files node
2024-11-13 09:22:56.586 [info] PullRequestTree> Review threads have changed, refreshing Commits node
2024-11-13 09:22:56.586 [info] PullRequestTree> Comments have changed, refreshing Files node
2024-11-13 09:22:56.586 [info] PullRequestTree> Comments have changed, refreshing Commits node

@Shamik-07
Copy link

I have the same error message and i encountered this when i was commenting on a PR.
Submitting review failed. GraphQL error: Fragment ReviewComment was used, but not defined

@kishaningithub
Copy link

Encountered the same issue. Below is a screenshot of the same...

Image

@QSC-Eugene
Copy link

Same error here trying to start a review
Image

@Shamik-07
Copy link

Temporary solution is to roll back one version.

@qcannon
Copy link

qcannon commented Nov 13, 2024

Having same issue as well 👍🏻 Going to roll back.

@chrmarti
Copy link
Contributor Author

Confirmed that this is in 0.100.1, but not in 0.100.0.

To go back to 0.100.0: F1 > Extensions: Install Specific Version of Extension... > GitHub Pull Requests > 0.100.0 and then restart extensions.

@MetRonnie
Copy link

Duplicate of #6467?

@jerimiahwelch
Copy link

Same issue here. Rolling back to v0.100.0 fixed it for me.

@chrmarti
Copy link
Contributor Author

Duplicate of #6467?

Indeed, continuing there, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants