Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't start a review from a comment due to GraphQL error #6467

Open
yoavbls opened this issue Nov 9, 2024 · 38 comments
Open

Can't start a review from a comment due to GraphQL error #6467

yoavbls opened this issue Nov 9, 2024 · 38 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release

Comments

@yoavbls
Copy link

yoavbls commented Nov 9, 2024

When starting a review from a comment:

A GraphQL error appears:

2024-11-09 22:52:00.572 [error] GitHubRepository+0> Error querying GraphQL API: GraphQL error: Fragment ReviewComment was used, but not defined. useAndDefineFragment
2024-11-09 22:52:00.572 [error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Fragment ReviewComment was used, but not defined

I thought it related to this: #6441 but it happens also in the pre-release version

  • Extension version: v0.100.1
  • VSCode Version: 1.95.2
  • OS: macOS
  • Repository Clone Configuration (single repository/fork of an upstream repository): Private repository
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

  1. Write a comment
  2. Click on "Start Review"
@yoavbls
Copy link
Author

yoavbls commented Nov 9, 2024

Update: it also affects the load of existing comments.
Everything is fine in the version of November 5 so I think it is this change that moves the fragment out of reach of the query: 8434973

@valajczech
Copy link

Yup I have the same problem

@BenGale
Copy link

BenGale commented Nov 10, 2024

Same problem.

@christianvari
Copy link

Same issue

@DavidLangva
Copy link

same. I also can't leave one off comments

@michel-smarticket
Copy link

Same

@YashBhardwajAdpushup
Copy link

same

@koliyo
Copy link

koliyo commented Nov 11, 2024

Workaround, rollback to older version locally: Right click the extension in the marketplace tab, select "Install Specific Version", and pick v0.100.0.

@consdu
Copy link

consdu commented Nov 11, 2024

thanks @koliyo

@jpomfret
Copy link

I have the same issue - confirmed the workaround works for me.

@ptraeg
Copy link

ptraeg commented Nov 11, 2024

@koliyo Thanks - that fixed it for me as well.

@tristanbiesecker
Copy link

Same problem for me as well. Workaround fixed it.

@jacobharrison93
Copy link

Same problem for me as well

@MatthewKelseyRT
Copy link

Same for me, the workaround fixed it.

@JoeLyga
Copy link

JoeLyga commented Nov 12, 2024

Same problem. The workaround avoids the issue.

@jirihon
Copy link

jirihon commented Nov 12, 2024

Same problem for me.

1 similar comment
@ian-blankinship-FHR
Copy link

Same problem for me.

@assafmo
Copy link

assafmo commented Nov 13, 2024

Rolling back to v0.100.0 fixed it, thanks @koliyo!

@Shamik-07
Copy link

Add me to this list as well

Image

@dwillhelm
Copy link

Same

@Shamik-07
Copy link

Rolling back to v0.100.0 fixed it, thanks @koliyo!

This works for now

@pelord
Copy link

pelord commented Nov 13, 2024

Rolling back to v0.100.0 fixed it.

@sg-tanner
Copy link

Rollback noted, just wanted to add that for weeks now I have had trouble with the extension in general loading the files changed when trying to expand the PR in the "Requests" pane. Wondering if this is related. Because I tried to skip the loading issue by right clicking the PR and selecting "Checkout pull request"

@baruchiro
Copy link

It's the same in review mode on the browser. Can revert to the previous version there

@gihankarunarathne
Copy link

Image
Facing the same issue when trying to add a comment.

Need quick support!

@UrielZohar
Copy link

UrielZohar commented Nov 14, 2024

BE CAREFUL WITH DOWNGRADE THE EXTENTION VERSION YOU WILL LOSE THE COMMENTS YOU ALREDY WROTE

@BenGale
Copy link

BenGale commented Nov 14, 2024

When I was running into the issue it looked like those comments are gone anyway, they never get through to GitHub.

@pereyra-m
Copy link

Same here

@patricio-hondagneu-simplisafe

Experiencing the same issue. Installing version v0.100.0 fixes it so it appears to be a regression.

@rubenarturopj
Copy link

Same issue

@ysuzuki19
Copy link

temporary solution

  1. If you have failed comment locally, you should memo it.
  2. Open Extensions (Ctrl+Shift+X)
  3. Find GitHub Pull Requests
  4. Open pull-down on Uninstall button
  5. Select Install Specific Version...
  6. Select 0.100.0
  7. Client Restart Extensions

@Ardrete
Copy link

Ardrete commented Nov 14, 2024

Same here, only rollbacking to version v0.98.0 worked for me, I am using github enterprise version 3.2.6

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Nov 15, 2024
@joaomoreno
Copy link
Member

Thanks @ysuzuki19 for providing steps for a workaround for the time being. We will release a fixed version early next week.

@arjentraas
Copy link

arjentraas commented Nov 15, 2024

Rolling back to a previous version (100.0, or 98.0) doesn't work for me. Using VSCode in WSL.

@klausbadelt
Copy link

Downgrading is not an option in GitHub Codespaces - "Install Specific Version..." is disabled for this extension.

Revewing PRs in Codespaces is therefore 100% broken, with no workaround.

Image

@klausbadelt
Copy link

Hi @alexr00 - since all PR reviews are broken in Codespaces, without any workaround (posted here), could this get a priority boost?

@bmlaw
Copy link

bmlaw commented Nov 17, 2024

GitHub Education user: Now we are unable to leave feedback on any of our students' work, since the GitHub Education feedback mechanism is through a pull request. It's the middle of November. This is not a good time to not be able to leave feedback on any of our students' work.

@michaelk-redis
Copy link

Same issue for me. Roll back to 0.100.0 version helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

No branches or pull requests