Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read launch config from devcontainers #388

Merged

Conversation

paulacamargo25
Copy link
Contributor

@paulacamargo25 paulacamargo25 commented Jul 17, 2024

  • Read config from devcontainers too
  • Fix local vsix creation

@paulacamargo25 paulacamargo25 added the bug Issue identified by VS Code Team member as probable bug label Jul 17, 2024
@paulacamargo25 paulacamargo25 added this to the July 2024 milestone Jul 17, 2024
@paulacamargo25 paulacamargo25 self-assigned this Jul 17, 2024
@eleanorjboyd
Copy link
Member

so this reads a launch.json config to clarify? Might be worth specifying in the issue title?

@paulacamargo25 paulacamargo25 changed the title Read config from devcontainers Read launch config from devcontainers Jul 18, 2024
@paulacamargo25
Copy link
Contributor Author

so this reads a launch.json config to clarify? Might be worth specifying in the issue title?

Yes, if you send the workspace it will also get the launch.json inside devcontainers.

@paulacamargo25 paulacamargo25 merged commit 481ccdb into microsoft:main Jul 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants