Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Change the gloabls for exec #108

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Conversation

LukeSlev
Copy link
Member

Description:

This PR fixes a bug found in user testing where functions didn't have access to the correct globals.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing:

  • write user code that uses an imported library in a function call. it should not crash

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes for great improvements 🚀
Works as expected thank you for the efficiency !

@LukeSlev LukeSlev merged commit e94e3c5 into dev Aug 12, 2019
@jonathanwangg jonathanwangg deleted the users/t-luslev/fix-function-globals branch August 26, 2019 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants