Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Fixing bug seeing which icon in the Simulator Control bar is Focused on when tabbing #116

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

Christellah
Copy link
Contributor

Description:

This is to fix the bug preventing the user to see which button is selected when they tab through the Simulator Control Bar.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing:

  • Try to tab through the Simulator Control bar and make sure you can see which icon is being focused on.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the code and tested it. We seem to still be able to tab to the "ends" of the simulator control bar (indicated in red). Is this something we want to disallow?

tabbable

The other remark is that the tabbing order of the touch sensors seems to be incorrect? The order seems to be 1, 2, 3, 6, 4, 5. Should we address that in this PR or another one?

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after edge button fix is made

@FMounz
Copy link
Contributor

FMounz commented Aug 15, 2019

Checked out the code and tested it. We seem to still be able to tab to the "ends" of the simulator control bar (indicated in red). Is this something we want to disallow?

The other remark is that the tabbing order of the touch sensors seems to be incorrect? The order seems to be 1, 2, 3, 6, 4, 5. Should we address that in this PR or another one?

If I am not mistaken that order is attached to the one the element are in the simulator SVG. So I don't think it would be worth it to change that

@Christellah
Copy link
Contributor Author

Christellah commented Aug 15, 2019

other remark is that the tabbing order of the touch sensors seems to be incorrect? The order seems to be 1, 2, 3, 6, 4, 5. Should we address that in this PR or another one?

@jonathanwangg It seems to have no clear way to change the order, but @LukeSlev found a solution for preventing tabbing in the edges

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Christellah Christellah merged commit 4dae998 into dev Aug 15, 2019
@Christellah Christellah deleted the users/t-chcido/fix-button-focus branch August 15, 2019 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants