Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Fix issue with tomorrow Night Blue Theme #120

Merged
merged 3 commits into from
Aug 15, 2019

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 15, 2019

Description:

This PR fix visibility issues when using the Tomorrow night blue theme. A new color contribution has been made in package.json to replace the badgeForeground color that was causing the issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@FMounz FMounz merged commit e2860b6 into dev Aug 15, 2019
@FMounz FMounz deleted the users/t-famoun/tomorrow-theme-fix branch August 17, 2019 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants