Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Adding a setting for the user to pick the port and passing it to the python process #123

Merged
merged 5 commits into from
Aug 19, 2019

Conversation

Christellah
Copy link
Contributor

Description:

This PR adds a setting so the user can change the port the server is listening on and passing it to the debugger python process. In order to do so we use an http server that we pass to socketio, and checking if that server was correctly started on the port selected.
If the server can't be initialize and the port is in use, you can't interact with the simulator but you can still debug the code and see the the variables changing.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing:

  • Try running the server on different port by changing the setting Pacifica : Debugger server port
  • Try running the server on an occupied port and check that you can debug but without the simulator

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@LukeSlev
Copy link
Member

@Christellah conflicts

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Christellah Christellah merged commit 43091a9 into dev Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants