Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Use absolute path instead relative to fix permission issue #126

Merged
merged 2 commits into from
Aug 19, 2019

Conversation

jonathanwangg
Copy link
Contributor

Description:

There was a permission issue on Mac where our code was trying to create the .vscode directory at the top level. By providing it an absolute path instead, there should be no permission issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

None

Testing:

  • Check that existing functionality of the extension is not broken on both Mac and Windows

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@jonathanwangg jonathanwangg changed the title Use absolute path instead relative to fix permission issue on Mac Use absolute path instead relative to fix permission issue Aug 19, 2019
@jonathanwangg jonathanwangg merged commit 48f9bb6 into dev Aug 19, 2019
@jonathanwangg jonathanwangg deleted the users/t-jowang/fix-vscode-permission branch August 23, 2019 01:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants